narendly commented on a change in pull request #924: WIP: fix
ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r401173555
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java
##########
@@ -112,4 +112,9 @@ public String create(final String path, Object datat,
final List<ACL> acl,
protected boolean isManagingZkConnection() {
return false;
}
+
+ // test only
+ public HelixZkClient getConnectionManager() {
+ return _connectionManager;
+ }
Review comment:
Can you avoid adding public methods like this that shouldn't otherwise be
used in production?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
