jiajunwang commented on issue #924: WIP: fix ZkHelixPropertyStore loses Zookeeper notification issue URL: https://github.com/apache/helix/pull/924#issuecomment-606942634 > @jiajunwang > > > I see the main issue is about the additional public method for fetching the client. I don't like that either. > > An alternative way is that, since you are for sure given a shared zkclient in that property store, you can call ShareZkClientFactory with the same parameters and it will return you with another shared ZkClient instance. But, since they will use the same connection manager, when you expires the newly created client, the one that in the HelixPropertyStore will also be expired for once. > > Can you have a try? In this way, no new method is required. > > How do we get the zkconnection manager from the new sharedZkClient? It is not public. > > If we make zkConnectionManager protected, we need to access it from the module in zookeeper-api, which means move (rewrite) this test case there. But this case use the code from HelixPropertyStore, which is helix-core. This is circular dependency. Why you need to get zkconnection manager? The object you operate on is the send shared zkclient that you get from the factory.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
