kaisun2000 commented on a change in pull request #924: WIP: fix
ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r401928444
##########
File path: helix-core/src/test/java/org/apache/helix/ZkTestHelper.java
##########
@@ -146,6 +146,70 @@ public void process(WatchedEvent event) {
LOG.info("After expiry. sessionId: " +
Long.toHexString(curZookeeper.getSessionId()));
}
+ public static void expireSharedZkClientSession(HelixZkClient client) throws
Exception {
+ final CountDownLatch waitExpireSession = new CountDownLatch(1);
+ final ZkClient zkClient = (ZkClient) client;
+
+ IZkStateListener listener = new IZkStateListener() {
+ @Override
+ public void handleStateChanged(KeeperState state) throws Exception {
+ LOG.info("IZkStateListener#handleStateChanged, state: " + state);
+ if (state == KeeperState.Expired) {
+ waitExpireSession.countDown();
Review comment:
You are right, here this latch guarantees expiring happens. But later, the
code still ensures new session established.
waitExpireSession.await();
zkClient.unsubscribeStateChanges(listener);
connection = (ZkConnection) zkClient.getConnection();
curZookeeper = connection.getZookeeper();
// wait util connected
while (curZookeeper.getState() != States.CONNECTED) {
Thread.sleep(10);
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
