NealSun96 opened a new pull request #933: Fix MetadataStoreDirectory routing data cache refresh bug URL: https://github.com/apache/helix/pull/933 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #927 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: This PR fixes the MetadataStoreDirectory routing data cache refresh bug. In `ZkMetadataStoreDirectory`, it is now ensured that routing data cache is cleared before updating; when an exception is raised, the old data is still erased correctly. Also, this PR fixes an edge case during `TrieRoutingData` creation. When there are zkRealms defined without a single sharding key, `TrieRoutingData` now correctly identifies the raw routing data as invalid and raise an exception. ### Tests - [x] The following is the result of the "mvn test" command on the appropriate module: ``` [ERROR] Tests run: 145, Failures: 1, Errors: 0, Skipped: 7, Time elapsed: 28.895 s <<< FAILURE! - in TestSuite [ERROR] testResourceHealth(org.apache.helix.rest.server.TestResourceAccessor) Time elapsed: 0.295 s <<< FAILURE! java.lang.AssertionError: expected:<HEALTHY> but was:<UNHEALTHY> at org.apache.helix.rest.server.TestResourceAccessor.testResourceHealth(TestResourceAccessor.java:289) [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestResourceAccessor.testResourceHealth:289 expected:<HEALTHY> but was:<UNHEALTHY> [INFO] [ERROR] Tests run: 145, Failures: 1, Errors: 0, Skipped: 7 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 33.443 s [INFO] Finished at: 2020-04-03T13:47:22-07:00 [INFO] ------------------------------------------------------------------------ ``` ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
