narendly commented on a change in pull request #933: Fix MetadataStoreDirectory
routing data cache refresh bug
URL: https://github.com/apache/helix/pull/933#discussion_r404962895
##########
File path:
metadata-store-directory-common/src/main/java/org/apache/helix/msdcommon/datamodel/TrieRoutingData.java
##########
@@ -48,6 +48,10 @@ public TrieRoutingData(Map<String, List<String>>
routingData)
throw new InvalidRoutingDataException("routingData cannot be null or
empty");
}
+ if (!containsShardingKey(routingData)) {
+ throw new InvalidRoutingDataException("routingData needs at least 1
sharding key");
+ }
Review comment:
Explain why this should be invalid? I thought we agreed that it's acceptable
to have a realm without any keys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
