jiajunwang opened a new pull request #941: Fix unexpceted partition movements in the CrushEd strategy. URL: https://github.com/apache/helix/pull/941 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: #940 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: This is a workaround fix to ensure backward compatibility. An additional cache map is used to keep the stable partition list so as to remove the randomness in the algorithm input. Note that the right fix would be cleaner that we sort the list inside the strategy class. However, that will also change all existing cluster assignments in production. ### Tests - [ ] The following tests are written for this issue: TestResourceControllerDataProvider.testStablePartitionListCache * Note that integration test is not quite doable unless we have a way to let JDK keySet() method return the same set with different iteration orders. Please comment if any good idea. - [ ] The following is the result of the "mvn test" command on the appropriate module: [ERROR] Failures: [ERROR] org.apache.helix.integration.rebalancer.CrushRebalancers.TestCrushAutoRebalanceTopoplogyAwareDisabled.testLackEnoughInstances(org.apache.helix.integration.rebalancer.CrushRebalancers.TestCrushAutoRebalanceTopoplogyAwareDisabled) [INFO] Run 1: PASS [ERROR] Run 2: TestCrushAutoRebalanceTopoplogyAwareDisabled.testLackEnoughInstances:86->TestCrushAutoRebalanceNonRack.testLackEnoughInstances:250 ยป ZkClient [INFO] [INFO] [ERROR] Tests run: 1119, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:15 h [INFO] Finished at: 2020-04-09T01:30:55-07:00 [INFO] ------------------------------------------------------------------------ Rerun failed test [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.3 s - in org.apache.helix.integration.rebalancer.CrushRebalancers.TestCrushAutoRebalanceTopoplogyAwareDisabled [INFO] [INFO] Results: [INFO] [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 27.453 s [INFO] Finished at: 2020-04-09T10:25:20-07:00 [INFO] ------------------------------------------------------------------------ ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [ ] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
