lei-xia commented on a change in pull request #941: Fix unexpceted partition 
movements in the CrushEd strategy.
URL: https://github.com/apache/helix/pull/941#discussion_r406854886
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java
 ##########
 @@ -64,7 +64,12 @@ public IdealState computeNewIdealState(String resourceName,
 
     LOG.info("Computing IdealState for " + resourceName);
 
-    List<String> partitions = new 
ArrayList<>(currentIdealState.getPartitionSet());
+    // This is part of the backward compatible workaround to fix
+    // https://github.com/apache/helix/issues/940.
+    // TODO: remove the workaround once we are able to apply the simple fix 
without majorly
 
 Review comment:
   When do you think we can fix it permanently?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to