narendly commented on a change in pull request #950: Fix failure of dropping
instance in TestCrushAutoRebalanceNonRack
URL: https://github.com/apache/helix/pull/950#discussion_r407758221
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
##########
@@ -235,9 +236,10 @@ public void dropInstance(String clusterName,
InstanceConfig instanceConfig) {
instanceConfig.getInstanceName(), e.getCause().getMessage());
retryCnt++;
} else {
- logger.error("Failed to drop instance {} (not retryable).",
- instanceConfig.getInstanceName(), e.getCause());
- throw e;
+ String errorMessage = "Failed to drop instance: " +
instanceConfig.getInstanceName()
+ + ". Retry times: " + retryCnt;
+ logger.error(errorMessage, retryCnt, e.getCause());
Review comment:
`logger.error(errorMessage, e);` should be good enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
