pkuwm commented on issue #950: Fix failure of dropping instance in TestCrushAutoRebalanceNonRack URL: https://github.com/apache/helix/pull/950#issuecomment-613178175 > Can you add more comments about why this logic related to OFFLINE -> DROPPED not dropping current states? @dasahcc I can't 100% confirm this would cause "OFFLINE -> DROPPED not dropping current states". There is a case this would cause current states not to be dropped: 1. getChildren(instance) returns: children: [ERRORS, MESSAGES, CURRENTSTATES, STATUSUPDATES, HISTORY]. Ordering is not guaranteed. MESSAGES might be before CURRENTSTATES. 2. deleting MESSAGES throws HelixException but it is not caught. 3. dropInstance() fails because of the HelixException. 4. And CURRENTSTATES is not yet deleted, because ordering of deleting in deleteRecursively is not guaranteed. I will update you once I confirm the root cause of: "OFFLINE -> DROPPED not dropping current states". Currently this PR will just fix dropInstance() issue because of mismatched exception type.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
