pkuwm opened a new pull request #955: Fix MSD routing data update methods URL: https://github.com/apache/helix/pull/955 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Fixes part of #939 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: 1. Routing data update methods in ZkMetadataStoreDirectory writes routing data to ZK and refresh routing cache. However, it should not refresh routing data if writing to ZK fails. Refreshing routing should only be proceeded if writing to ZK is successful. 2. The test is flaky because of removing namespace when refreshing routing data. It is caused by race condition between the read request after updating and data change callback to refresh routing (which is second refresh). Namespace should only be removed when exception is thrown. ### Tests - [ ] The following tests are written for this issue: Fix TestZkMetadataStoreDirectory - [ ] The following is the result of the "mvn test" command on the appropriate module: Before: TestZkMetadataStoreDirectory failed within 5 attempts. After: 50 attempts of running TestZkMetadataStoreDirectory passed In helix-rest: ``` [ERROR] Failures: [ERROR] TestClusterAccessor.testGetControllerLeadershipHistory:364 expected:<true> but was:<false> [ERROR] TestJobAccessor.testDeleteJob:206 ยป Helix Fail to stop the workflow/queue Test... [INFO] [ERROR] Tests run: 155, Failures: 2, Errors: 0, Skipped: 15 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 45.246 s [INFO] Finished at: 2020-04-14T21:12:45-07:00 [INFO] ------------------------------------------------------------------------ [INFO] Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.402 s - in org.apache.helix.rest.server.TestClusterAccessor [INFO] [INFO] Results: [INFO] [INFO] Tests run: 28, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 30.602 s [INFO] Finished at: 2020-04-14T21:14:10-07:00 [INFO] ------------------------------------------------------------------------ [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.28 s - in org.apache.helix.rest.server.TestJobAccessor [INFO] [INFO] Results: [INFO] [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 26.061 s [INFO] Finished at: 2020-04-14T21:17:40-07:00 [INFO] ------------------------------------------------------------------------ ``` ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [ ] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
