NealSun96 commented on a change in pull request #955: Fix MSD routing data
refreshing for update methods
URL: https://github.com/apache/helix/pull/955#discussion_r408975123
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/metadatastore/TestZkMetadataStoreDirectory.java
##########
@@ -344,6 +345,10 @@ public void testDataDeletionCallback() throws Exception {
+ " contains either empty or invalid routing data!")) {
return false;
}
+ } catch (IllegalArgumentException iae) {
+ if (!iae.getMessage().equals("Provided path is not a valid Zookeeper
path: anyKey")) {
+ return false;
Review comment:
The meaning of the block on line 343 is "ensure that an
`IllegalStateException` is raised and the message is 'Failed to get...'". Is
this block ensuring a `IllegalArgumentException` is raised? That's not what
this test case is testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
