NealSun96 opened a new pull request #973:
URL: https://github.com/apache/helix/pull/973


   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the 
PR description:
   
   Fixes #972
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   We are improving the task framework by allowing task thread pools to have 
configurable sizes. As a part of the participant side change, 
`TaskStateModelFactory` is changed to allocate thread pool sizes based on 
values provided in `InstanceConfig` or `ClusterConfig`.
   
   Both `InstanceConfig` and `ClusterConfig` are now expected to contain a 
field keyed as "TARGET_TASK_THREAD_POOL_SIZE", where the value for 
`InstanceConfig` only determines the thread pool size for the specified 
instance, and the value for `ClusterConfig` determines the thread pool sizes 
for all instances of that cluster. If `InstanceConfig` isn't able to provide 
the pool size, then `ClusterConfig` will be used to determine the pool size; if 
neither of them are able to provide the pool size, `TaskStateModelFactory` will 
use a default value.
   
   ### Tests
   
   - [] The following is the result of the "mvn test" command on the 
appropriate module:
   
   
   ### Commits
   
   - [] My commits all reference appropriate Apache Helix GitHub issues in 
their subject lines. In addition, my commits follow the guidelines from "[How 
to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to