narendly commented on a change in pull request #973:
URL: https://github.com/apache/helix/pull/973#discussion_r416940613
##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -137,6 +140,7 @@
private final static int MAX_REBALANCE_PREFERENCE = 10;
private final static int MIN_REBALANCE_PREFERENCE = 0;
public final static boolean DEFAULT_GLOBAL_REBALANCE_ASYNC_MODE_ENABLED =
true;
+ public static final int TARGET_TASK_THREAD_POOL_SIZE_NOT_SET = -1;
Review comment:
Why does this need to be a public field?
Also, it seems that this constant and some of the other enums are duplicated
in different places. Is it possible to put this in one place? (Hint.
TaskConstants.java)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
