alirezazamani opened a new pull request #981: URL: https://github.com/apache/helix/pull/981
### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #977 Fixes #978 Fixes #979 Fixes #980 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: TestJobFailure was unstable because we get ExternalView of a resources and if the ExternalView is not populated yet by the controller, we hit NullPointerException. TestRebalanceRunningTask was unstable. In this PR, we make sure that the master is existed in two different nodes (master is switched to new instance) and then we check the assigned participants. TestRebalanceStopAndResume was unstable because of Thread.Sleep usage. Instead of stopping the workflow after some time, we first make sure that workflow and job is IN_PROGRESS and then stop the workflow. TestTaskSchedulingTwoCurrent has been stabilized by making sure that master has been switched to new instance after modifying IS. After that we make sure that task is assigned to the correct instance and make sure it does not switched to new instance and cancel is not being called incorrectly. ### Tests - [x] The following is the result of the "mvn test" command on the appropriate module: Test Result: [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestTaskRebalancer.timeouts:200 expected:<true> but was:<false> [ERROR] TestWorkflowTermination.testWorkflowRunningTimeout:131->verifyWorkflowCleanup:257 expected:<true> but was:<false> [ERROR] TestClusterVerifier.testResourceSubset:225 expected:<false> but was:<true> [INFO] [ERROR] Tests run: 1144, Failures: 3, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:18 h [INFO] Finished at: 2020-04-29T11:25:52-07:00 [INFO] ------------------------------------------------------------------------ The failed tests has passed when I ran it individually. The failed tests also need to be stabilized later ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
