alirezazamani commented on a change in pull request #981:
URL: https://github.com/apache/helix/pull/981#discussion_r417693833
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/task/TestJobFailure.java
##########
@@ -118,8 +118,15 @@ public void testNormalJobFailure(String comment,
List<String> taskStates,
}
private Map<String, Map<String, String>> createPartitionConfig(List<String>
taskStates,
- List<String> expectedTaskEndingStates) {
+ List<String> expectedTaskEndingStates) throws Exception {
Map<String, Map<String, String>> targetPartitionConfigs = new HashMap<>();
+ // Make sure external view is has been created for the resource
+ boolean isExternalViewCreated = TestHelper.verify(() -> {
+ ExternalView externalView =
+
_manager.getClusterManagmentTool().getResourceExternalView(CLUSTER_NAME,
DB_NAME);
+ return (externalView != null);
+ }, TestHelper.WAIT_DURATION);
+ Assert.assertTrue(isExternalViewCreated);
Review comment:
Good suggestion. Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
