kaisun2000 commented on a change in pull request #1000:
URL: https://github.com/apache/helix/pull/1000#discussion_r425319650
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -1135,6 +1145,34 @@ private void removeMessageFromZK(HelixDataAccessor
accessor, Message message,
}
}
+ private void startMessageRefreshThread() {
Review comment:
How about let us add a comment about the reason why we add this thread?
Something like:
Async batch read has bug that prevent it from reading all the messages
successfully. The issue is separately addressed by pull request [xxxx]. We also
add this one as periodical "pull" messages from ZkServer method to preemptively
read and process messages from controller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
