kaisun2000 commented on a change in pull request #1000:
URL: https://github.com/apache/helix/pull/1000#discussion_r425487301
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -1135,6 +1145,34 @@ private void removeMessageFromZK(HelixDataAccessor
accessor, Message message,
}
}
+ private void startMessageRefreshThread() {
+ int periodicMessageRefreshInterval =
+
HelixUtil.getSystemPropertyAsInt(SystemPropertyKeys.PERIODIC_MESSAGE_REFRESH_INTERVAL,
-1);
Review comment:
Another point is that:
OnMessage called by the timer thread can throw exception. The thing is that
I suspect that timer's internal thread may not schedule more OnMessage() if the
previous one has exception thrown. This needs to be tested and verified.
Otherwise, the timer thread may never work after exception thrown if my
suspicion is right.
Java Concurrency Control book talked in detail about this issue. I suggest
let at least let test throwing exception from OnMessage and see if this is a
problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
