alirezazamani commented on a change in pull request #1013:
URL: https://github.com/apache/helix/pull/1013#discussion_r427570458
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientFactory.java
##########
@@ -44,14 +51,17 @@ public static CustomRestClient get() {
if (INSTANCE == null) {
try {
HttpClient httpClient;
+ RequestConfig config =
RequestConfig.custom().setConnectTimeout(_httpRequestTimeout)
+ .setConnectionRequestTimeout(_httpRequestTimeout)
+ .setSocketTimeout(_httpRequestTimeout).build();
Review comment:
I think we prefer to have a timeout for any reason and not be blocked to
query SN. That is why I used both of them as same value. Also I noticed that we
do same for other classes such as HttpRoutingDataReader. I do not have strong
preferences about this. I feel we should reduce the amount of configs as much
as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
