alirezazamani commented on a change in pull request #1013:
URL: https://github.com/apache/helix/pull/1013#discussion_r427645571



##########
File path: 
helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java
##########
@@ -130,6 +131,11 @@ protected HttpResponse post(String url, Map<String, 
String> payloads) throws IOE
       LOG.info("Executing request: {}, headers: {}, entity: {}", 
postRequest.getRequestLine(),
           postRequest.getAllHeaders(), postRequest.getEntity());
       return _httpClient.execute(postRequest);
+    } catch (ConnectTimeoutException e) {
+      LOG.error(
+          "Failed to perform customized health check due to 
ConnectTimeoutException for endpoint {}.",
+          url, e);
+      throw e;

Review comment:
       Removed the log and exception as it will be catched (IOException) by 
upper methods. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to