lei-xia commented on a change in pull request #1035:
URL: https://github.com/apache/helix/pull/1035#discussion_r431579266
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/RealmAwareZkClient.java
##########
@@ -71,10 +71,14 @@
// listener subscription
List<String> subscribeChildChanges(String path, IZkChildListener listener);
+ List<String> subscribeChildChanges(String path, IZkChildListener listener,
boolean skipWatchingNodeNotExist);
+
void unsubscribeChildChanges(String path, IZkChildListener listener);
void subscribeDataChanges(String path, IZkDataListener listener);
+ void subscribeDataChanges(String path, IZkDataListener listener, boolean
skipWatchingNodeNotExist);
Review comment:
Can we add some java doc here to explain the parameters and the
differences between two methods with same name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
