lei-xia commented on a change in pull request #1035:
URL: https://github.com/apache/helix/pull/1035#discussion_r431580728
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -1858,24 +1923,47 @@ public Object call() throws Exception {
});
}
+ private boolean watchForData(final String path, boolean
skipWatchingNodeNotExist) {
+ try {
+ if (skipWatchingNodeNotExist) {
+ Stat stat = new Stat();
+ retryUntilConnected(() -> (((ZkConnection)
getConnection()).getZookeeper().getData(path, true, stat)));
Review comment:
I think we did not discuss the performance impact here, now most of the
time we are using getData() instead of exist(), which could increase read
traffic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
