jiajunwang commented on a change in pull request #1031:
URL: https://github.com/apache/helix/pull/1031#discussion_r432161839
##########
File path: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java
##########
@@ -140,6 +160,82 @@ public static String serializeByComma(List<String>
objects) {
}
}
+ /**
+ * Returns the expected ideal ResourceAssignments for the given resources in
the cluster
+ * calculated using the read-only WAGED rebalancer.
+ * @param metadataStoreAddress
+ * @param clusterConfig
+ * @param instanceConfigs
+ * @param liveInstances
+ * @param newIdealStates
Review comment:
The "new" here might be confusing. So the requirement here is, actually,
the caller should include all the resource IS/Configs into the input, right?
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/WagedRebalancer/TestWagedRebalance.java
##########
@@ -164,7 +214,7 @@ public void testWithInstanceTag() throws Exception {
validate(_replica);
}
- @Test(dependsOnMethods = "test")
+ @Test(dependsOnMethods = "testRebalanceTool")
Review comment:
nit, but why the other tests need to depend on testRebalanceTool?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
