jiajunwang commented on a change in pull request #1031:
URL: https://github.com/apache/helix/pull/1031#discussion_r432166903
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/WagedRebalancer/TestWagedRebalance.java
##########
@@ -164,7 +214,7 @@ public void testWithInstanceTag() throws Exception {
validate(_replica);
}
- @Test(dependsOnMethods = "test")
+ @Test(dependsOnMethods = "testRebalanceTool")
Review comment:
I would prefer to configure the tests in a way of real logic
dependencies. Easier for us to maintain.
Moreover, I think we won't remember why it was initially done like this. Let
do it in a meaningful way the first time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
