pkuwm commented on a change in pull request #1035:
URL: https://github.com/apache/helix/pull/1035#discussion_r432192320
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/RealmAwareZkClient.java
##########
@@ -71,10 +71,14 @@
// listener subscription
List<String> subscribeChildChanges(String path, IZkChildListener listener);
+ List<String> subscribeChildChanges(String path, IZkChildListener listener,
boolean skipWatchingNodeNotExist);
Review comment:
I think we need a default API for this. In helix we have all
implementation for this interface. But how about outside implementation? This
is for reference I did before. I think we should do the same thing.
```
/*
* This is for backwards compatibility.
*
* TODO: remove below default implementation when getting rid of I0Itec in
the new zk client.
*/
default void subscribeStateChanges(final IZkStateListener listener) {
subscribeStateChanges(new I0ItecIZkStateListenerImpl(listener));
}
/*
* This is for backwards compatibility.
*
* TODO: remove below default implementation when getting rid of I0Itec in
the new zk client.
*/
default void unsubscribeStateChanges(IZkStateListener listener) {
unsubscribeStateChanges(new I0ItecIZkStateListenerImpl(listener));
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
