kaisun2000 commented on a change in pull request #1035:
URL: https://github.com/apache/helix/pull/1035#discussion_r432274564
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/RealmAwareZkClient.java
##########
@@ -69,12 +69,44 @@
int DEFAULT_SESSION_TIMEOUT = 30 * 1000;
// listener subscription
+ /**
+ * Subscribe the path and the listener will handle child events of the path.
+ * Add exists watch to path if the path does not exist in ZooKeeper server.
+ * WARNING: if the path is created after deletion, users need to
re-subscribe the path
+ * @param path The zookeeper path
+ * @param listener Instance of {@link IZkDataListener}
+ */
List<String> subscribeChildChanges(String path, IZkChildListener listener);
+ /**
+ * Subscribe the path and the listener will handle child events of the path
+ * WARNING: if the path is created after deletion, users need to
re-subscribe the path
+ * @param path The zookeeper path
+ * @param listener Instance of {@link IZkDataListener}
+ * @param skipWatchingNodeNotExist Ture means not installing any watch if
path does not exist.
+ */
+ List<String> subscribeChildChanges(String path, IZkChildListener listener,
boolean skipWatchingNodeNotExist);
+
void unsubscribeChildChanges(String path, IZkChildListener listener);
+ /**
+ * Subscribe the path and the listener will handle data events of the path
+ * Add the exists watch to Zookeeper server even if the path does not exists
in zookeeper server
+ * WARNING: if the path is created after deletion, users need to
re-subscribe the path
+ * @param path The zookeeper path
+ * @param listener Instance of {@link IZkDataListener}
+ */
void subscribeDataChanges(String path, IZkDataListener listener);
+ /**
+ * Subscribe the path and the listener will handle data events of the path
+ * WARNING: if the path is created after deletion, users need to
re-subscribe the path
+ * @param path The zookeeper path
+ * @param listener Instance of {@link IZkDataListener}
+ * @param skipWatchingNodeNotExist Ture means not installing any watch if
path does not exist.
+ */
+ void subscribeDataChanges(String path, IZkDataListener listener, boolean
skipWatchingNodeNotExist);
Review comment:
This is a good point. I also thought about it.
We can make this one
`boolean subscribeDataChanges(String path, IZkDataListener listener,
boolean skipWatchingNodeNotExist);`
return boolean indicates whether the installation is successful or not.
Let us sync about it offline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
