narendly commented on a change in pull request #1043:
URL: https://github.com/apache/helix/pull/1043#discussion_r433001675
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Topology.java
##########
@@ -55,16 +55,10 @@
private final List<String> _liveInstances;
private final Map<String, InstanceConfig> _instanceConfigMap;
private final ClusterConfig _clusterConfig;
- private final boolean _topologyAwareEnabled;
+ private final String _defaultPathPrefix = "Helix_default_";
Review comment:
Please review the convention for defining constant Strings in Java.
https://stackoverflow.com/questions/9639007/defining-constant-string-in-java
With that said, is this prefix necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
