xyuanlu opened a new pull request #1043:
URL: https://github.com/apache/helix/pull/1043
### Issues
- [X] My PR addresses the following Helix issues and references them in the
PR description:
#1042 Validate instance topology configuration before let it comes online
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
We need sanity check for topology definition in InstanceConfig in multiple
places. Since we already have sanity check logic in
controller/rebalancer/topology/Topology.java and
controller/rebalancer/waged/model/AssignableNode.java, it's better to extract
the logic into an single util function first and use the same logic to do
sanity check in multiple places.
This PR is the first PR for issue #1042. It extracts the sanity check in
multiple functions into one single function in Topology.java to align with the
topology verification logic in AssignableNode.java.
There is one minor behavior change compared to the old version: If there is
a key in InstanceConfig.DOMAIN not defined in clusterConfig.topology, we skip
the key silently same as how its done in AssignableNode.java. In the old code,
we used to add a
warning in log.
### Tests
- [X] The following tests are written for this issue:
No new test is added since this PR is code clean up.
- [X] The following is the result of the "mvn test" command on the
appropriate module:
`[ERROR] Failures:
[ERROR]
org.apache.helix.integration.TestDisablePartition.testDisableFullAuto(org.apache.helix.integration.TestDisablePartition)
[ERROR] Run 1: TestDisablePartition.testDisableFullAuto:202
expected:<OFFLINE> but was:<STANDBY>
[INFO] Run 2: PASS
[INFO]
[ERROR]
TestControllerLeadershipChange.testMissingTopStateDurationMonitoring:262
expected:<true> but was:<false>
[ERROR] TestStateTransitionTimeout.testStateTransitionTimeOut:166
expected:<true> but was:<false>
[ERROR]
TestStateTransitionTimeoutWithResource.testStateTransitionTimeOut:174
expected:<true> but was:<false>
[INFO]
[ERROR] Tests run: 1147, Failures: 4, Errors: 0, Skipped: 1
[INFO]
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
11.198 s - in
org.apache.helix.integration.controller.TestControllerLeadershipChange
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.333
s - in org.apache.helix.integration.paticipant.TestStateTransitionTimeout
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.97
s - in
org.apache.helix.integration.paticipant.TestStateTransitionTimeoutWithResource
[INFO]
`
### Commits
- [X] My commits all reference appropriate Apache Helix GitHub issues in
their subject lines. In addition, my commits follow the guidelines from "[How
to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [X] In case of new functionality, my PR adds documentation in the
following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [X] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
