NealSun96 opened a new pull request #1056: URL: https://github.com/apache/helix/pull/1056
### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #1020 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: We are adding 3 endpoints to TaskDriver that return values of `SubmissionToProcessDelay`, `SubmissionToScheduleDelay`, and `ControllerInducedDelay`. The purpose of the endpoints is to offer an option for users that cannot rely directly on the controller emitted metrics to see the metric values. In order for the metrics to be accessible from TaskDriver, the metric values are written to ZooKeeper every time a new metric value is reported. The metric values that are synced to Zk is the mean value. Note: since they are synced on reporting time, if there is no reporting, there is no update to these values. These endpoint values are fresh when there are task framework resources actively running. ### Tests - [x] The following tests are written for this issue: TestJobMonitor, testGetSubmissionToProcessDelay, testGetSubmissionToProcessDelayIllegalArgument, testGetSubmissionToScheduleDelay, testGetSubmissionToScheduleDelayIllegalArgument, testControllerInducedDelay, testControllerInducedDelayIllegalArgument - [x] The following is the result of the "mvn test" command on the appropriate module: ``` [ERROR] Failures: [ERROR] TestEnableCompression.testEnableCompressionResource:117 expected:<true> but was:<false> [ERROR] TestStateTransitionTimeoutWithResource.testStateTransitionTimeOut:171 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 1178, Failures: 2, Errors: 0, Skipped: 1 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:16 h [INFO] Finished at: 2020-06-02T19:20:23-07:00 [INFO] ------------------------------------------------------------------------ ``` Rerun: ``` [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 38.517 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 43.765 s [INFO] Finished at: 2020-06-03T09:14:54-07:00 [INFO] ------------------------------------------------------------------------ ``` ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
