dasahcc commented on a change in pull request #1056:
URL: https://github.com/apache/helix/pull/1056#discussion_r435444072
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/JobMonitor.java
##########
@@ -41,6 +45,12 @@
private static final Logger LOG = LoggerFactory.getLogger(JobMonitor.class);
private static final long DEFAULT_RESET_INTERVAL_MS = 60 * 60 * 1000; // 1
hour
+ // The root path of ZNodes that are used to sync certain metrics to
ZooKeeper. This path is the
+ // first level, and its children nodes will represent each job type. Since
the metrics are
+ // aggregated by job types, the metric values will be recorded in each ZNode
belonging to a job
+ // type as simple fields.
+ private static final String SYNC_ZK_ROOT_PATH = "/JOB_MONITOR_METRICS";
Review comment:
It's now necessary for doing in this way:
1. These metrics can be done in controller by looking at the stats of the
ZNode property.
2. Even if you would like to have it in client side. You should make it
reported in MBean since all the data can be derived from config/context. So
ingraph can fetch MBean to report it. This is not a good idea to have metrics
reporting to introduce new ZNode create/read/write.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
