Then could you explain the cases? In the logic, it is ignoring parent path. Otherwise the code logic is not what you expect?
On Wed, Jun 3, 2020 at 11:04 PM GitBox <[email protected]> wrote: > > kaisun2000 commented on a change in pull request #1035: > URL: https://github.com/apache/helix/pull/1035#discussion_r435010918 > > > > ########## > File path: > helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java > ########## > @@ -555,7 +563,7 @@ private void subscribeDataChange(String path, > NotificationContext.Type callbackT > logger.debug(_manager.getInstanceName() + " subscribe > data-change. path: " + path > + ", listener: " + _listener); > } > - _zkClient.subscribeDataChanges(path, this); > + _zkClient.subscribeDataChanges(path, this, callbackType != > Type.INIT); > > Review comment: > If CallbackType is CALLBACK, ignore it is just want we want. That > is exactly the case of async removal of a task current state node from > server would do. > > If CallbackType is INIT, it would not fail. > > > > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
