kaisun2000 commented on a change in pull request #1035:
URL: https://github.com/apache/helix/pull/1035#discussion_r435014616
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -748,6 +756,10 @@ public void handleChildChange(String parentPath,
List<String> currentChilds) {
// removeListener will call handler.reset(), which in turn call
invoke() on FINALIZE type
_manager.removeListener(_propertyKey, _listener);
} else {
+ if (!isReady()) {
+ // avoid leaking CallbackHandler
Review comment:
Actually added on info log as this only happens when session expires.
Comparing to other info logs, this is not excessive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
