narendly commented on a change in pull request #1056:
URL: https://github.com/apache/helix/pull/1056#discussion_r435512469
##########
File path:
helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -1240,16 +1240,18 @@ protected void finishJobInRuntimeJobDag(TaskDataCache
clusterDataCache, String w
/**
* TODO: Move this logic to Task Framework metrics class for refactoring.
- * Computes and passes on submissionToProcessDelay to the dynamic metric.
+ * Computes and passes on submissionToProcessDelay to the dynamic metric;
syncs the metric to
+ * ZooKeeper
* @param dataProvider
* @param clusterStatusMonitor
* @param workflowConfig
* @param jobConfig
* @param currentTimestamp
+ * @param helixManager
*/
protected static void
reportSubmissionToProcessDelay(BaseControllerDataProvider dataProvider,
final ClusterStatusMonitor clusterStatusMonitor, final WorkflowConfig
workflowConfig,
- final JobConfig jobConfig, final long currentTimestamp) {
+ final JobConfig jobConfig, final long currentTimestamp, final
HelixManager helixManager) {
Review comment:
It's strongly recommend we check whether the given ZkConnection is
valid. What if helixManager is null or not connected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
