pkuwm commented on pull request #1066: URL: https://github.com/apache/helix/pull/1066#issuecomment-639774314
Got it. Thanks for pointing that out. I will get a better name for it. Maybe "ZkSessionWrapper". If you have a better name, please let me know. On Fri, Jun 5, 2020 at 12:52 PM Lei Xia <[email protected]> wrote: > *@lei-xia* commented on this pull request. > ------------------------------ > > In helix-core/src/main/java/org/apache/helix/HelixManager.java > <https://github.com/apache/helix/pull/1066#discussion_r436132217>: > > > @@ -425,6 +426,19 @@ void addExternalViewChangeListener(org.apache.helix.ExternalViewChangeListener l > */ > boolean isLeader(); > > + /** > + * Checks if the cluster manager is leader and sets its ZK session in > + * {@link ControllerLeaderSession}. > + * > + * @param controllerLeaderSession To include ZK session of the cluster manager in return > + * > + * @return true if this is a controller and a leader of the cluster. Zk session of the cluster > + * manager is set in controllerLeaderSession > + */ > + default boolean isLeader(ControllerLeaderSession controllerLeaderSession) { > > This could be confusion because there is no "leader" concept for a Helix > manager. Leader only applies to a controller instance, but HelixManager is > a broader concept here. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/helix/pull/1066#pullrequestreview-425585806>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABHSRCM4ZMRIF3VAWDW7VQTRVFEHHANCNFSM4NU6ODJA> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
