pkuwm commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r437946281
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -401,6 +402,8 @@ void checkConnected(long timeout) {
throw new HelixException(
"HelixManager is not connected within retry timeout for cluster " +
_clusterName);
}
+
+ _sessionId = ZKUtil.toHexSessionId(_zkclient.getSessionId());
Review comment:
I was waiting for you to point it out and discuss :) I had the same
thought when I considered adding this assignment. _sessionId is only assigned
in waitUntilConnected(). Each time handleNewSession() also calls
waitUntilConnected(). handleNewSession(expectedSession) handles expected
session. If the sessionId changes before handleNewSession() is done, I expect
handleNewSession() should be able to handle the expired session because it is
handling an expected session? Maybe I miss some corner cases? Let's carefully
think about this here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
