zhangmeng916 opened a new pull request #1068:
URL: https://github.com/apache/helix/pull/1068


   ### Issues
   
   - [X] My PR addresses the following Helix issues and references them in the 
PR description:
   
   (#1067 )
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI 
changes:
   This PR remove the waiting on existing pending message if the message is 
already processed and current state has already been updated. This would help 
generate message earlier and increase the rate of P2P message.
   
   ### Tests
   
   - [X] The following tests are written for this issue:
   Two tests are heavily modified:
   TestP2PMessagesAvoidDuplicatedMessage
   TestP2PStateTransitionMessages
   
   - [X] The following is the result of the "mvn test" command on the 
appropriate module:
   helix-core:[ERROR] Failures: 
   [ERROR]   TestRebalancePipeline.testMsgTriggeredRebalance:203 
expected:<true> but was:<false>
   [ERROR]   TestJobQueueCleanUp.testJobQueueAutoCleanUp ยป ThreadTimeout Method 
org.testng....
   [ERROR]   TestWorkflowTimeout.testWorkflowTimeoutWhenWorkflowCompleted:116 
expected:<true> but was:<false>
   [INFO] 
   [ERROR] Tests run: 1147, Failures: 3, Errors: 0, Skipped: 1
   [INFO] 
   [INFO] 
------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] 
------------------------------------------------------------------------
   [INFO] Total time:  01:21 h
   [INFO] Finished at: 2020-06-05T10:50:47-07:00
   
   ### Commits
   
   - [X] My commits all reference appropriate Apache Helix GitHub issues in 
their subject lines. In addition, my commits follow the guidelines from "[How 
to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [X] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to