jiajunwang commented on a change in pull request #1068:
URL: https://github.com/apache/helix/pull/1068#discussion_r439067826
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
##########
@@ -225,6 +225,13 @@ private void generateMessage(final Resource resource,
final BaseControllerDataPr
// pending message's toState (no cancellation message should be
generated in this case)
if (pendingMessage == null || (message == null &&
Review comment:
What happened to this condition?
Aren't they duplicate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
