jiajunwang opened a new pull request #1098: URL: https://github.com/apache/helix/pull/1098
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: (#200 - Link your issue number here: You can write "Fixes #XXX") ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: This is to fix a regression that was introduced by PR #986 The PR tried to prioritize the preference list to avoid unnecessary top state transitions. However, there was a bug in the prioritizing logic and if one participant is skipped due to low priority, it won't be picked up again during the calculating. As a result, this participant won't be assigned with any replica even it is originally in the preference list. This only happens if the state model has been customized so it is multiple top states and there is an intermediate state with expected count -1 between the top state and the other states. This fix will ensure the skipped participant being checked again until it gets the assignment. ### Tests - [X] The following tests are written for this issue: TestAbstractRebalancer.java Added test data that simulate a customized state model fits the problem statement. - [ ] The following is the result of the "mvn test" command on the appropriate module: Running ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
