jiajunwang commented on a change in pull request #1098:
URL: https://github.com/apache/helix/pull/1098#discussion_r441737560
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/rebalancer/TestAbstractRebalancer.java
##########
@@ -56,11 +56,11 @@ public void testComputeBestPossibleState(String comment,
String stateModelName,
new IdealState("test"), new ClusterConfig("TestCluster"),
partition,
MonitoredAbnormalResolver.DUMMY_STATE_RESOLVER);
- Assert.assertEquals(bestPossibleMap, expectedBestPossibleMap);
+ Assert.assertTrue(bestPossibleMap.equals(expectedBestPossibleMap));
Review comment:
This is an Assert bug. assertEquals does not work for mapping or list.
In general, it is doing left join. We want inner join : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
