jiajunwang commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r441951917
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java
##########
@@ -372,6 +372,12 @@ public void asyncCreate(String path, Object datat,
CreateMode mode,
_rawZkClient.asyncCreate(path, datat, mode, cb);
}
+ @Override
+ public void asyncCreate(String path, Object datat, CreateMode mode,
Review comment:
It's better to support this API for the dedicated zkclient only. For the
other clients, especially the customer-facing ones, I would prefer not to open
this API for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
