narendly commented on a change in pull request #1107:
URL: https://github.com/apache/helix/pull/1107#discussion_r443164608
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java
##########
@@ -329,32 +330,34 @@ public void close() {
disconnect();
}
- private void updateGCTimer(String rootPath, String currentVersion) {
- TimerTask gcTask = new TimerTask() {
- @Override
- public void run() {
+ private synchronized void updateGCTimer(String rootPath, long
currentVersion) {
+ if (_gcTaskFuture != null) {
+ _gcTaskFuture.cancel(false);
+ }
Review comment:
Do we really need to cancel? What if that causes incomplete deletion of
stale versions? I think we should let it queue up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
