jiajunwang commented on a change in pull request #1107:
URL: https://github.com/apache/helix/pull/1107#discussion_r443865176
##########
File path:
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java
##########
@@ -126,8 +133,17 @@ public void testMultipleWrites() throws Exception {
// Use Verifier because GC can take ZK delay
Assert.assertTrue(TestHelper.verify(() -> {
List<String> children = _zkBaseDataAccessor.getChildNames(PATH,
AccessOption.PERSISTENT);
- return children.size() == 3;
- }, 60 * 1000L));
+ return children.size() == 3 && children.containsAll(ImmutableList
+ .of(LAST_SUCCESSFUL_WRITE_KEY, LAST_WRITE_KEY,
+ new Long(lastSuccessfulWriteVer).toString()));
+ }, VERSION_TTL_MS * 2));
+
+ // Wait one more TTL to ensure that the
Review comment:
Good catch. I missed this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
