pkuwm commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r445370335
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -1740,27 +1707,34 @@ public Stat writeDataGetStat(final String path, Object
datat, final int expected
public void asyncCreate(final String path, Object datat, final CreateMode
mode,
final ZkAsyncCallbacks.CreateCallbackHandler cb) {
+ asyncCreate(path, datat, mode, cb, null);
+ }
+
+ public void asyncCreate(final String path, Object data, final CreateMode
mode,
Review comment:
@kaisun2000 You've got an eye on it. We have a discussion here regarding
the new API vs new interface:
https://github.com/apache/helix/pull/1066#discussion_r437912277
You may put some opinions there :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
