pkuwm commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r445372711
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java
##########
@@ -372,6 +372,12 @@ public void asyncCreate(String path, Object datat,
CreateMode mode,
_rawZkClient.asyncCreate(path, datat, mode, cb);
}
+ @Override
+ public void asyncCreate(String path, Object datat, CreateMode mode,
Review comment:
There is trade-off: with additional interfaces, we need to maintain the
additional interfaces, and we need to change the zkclient type with
SessionAwareZkClient in HelixManager as well, because these BaseDataAccessors
are using the zkclient in helix manager underneath. Let's discuss it further :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
