xyuanlu opened a new pull request #1129: URL: https://github.com/apache/helix/pull/1129
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: #1042 ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: Helix does not check if an instance's topology config is defined correctly when the instance is added or joins cluster. This will cause Helix to fail the rebalance. This change adds the sanity check when 1. Instance joins cluster 2. User update InstanceConfig using RestApi 3. Controller prepares the topology structure for rebalance <-- Currently we only check here This change also centralized the logic for topology sanity check. There are 2 behavior change for AssignableNode.computeFaultZone. The new logic is the same as in class Topology. It is better to have a centralized util function for both places. The two behavior changes are: 1. Originally, if clusterConfig.topology is null and Instance zoneId is none, AssignableNode.computeFaultZone will use instance's name while the logic in Topology class throws exception. 2. Originally, if clusterConfig.topology is not null but clusterConfig.faultZoneType is null, AssignableNode.computeFaultZone will throw exception while the logic in Topology class uses the last valid type in clusterConfig.topology. This changes makes the behavior consistent and use the logic in Topology class. ### Tests - [X] The following tests are written for this issue: TestParticipantManager.testValidateDeltaInstanceConfigForUpdate TestPerInstanceAccessor.simpleIntegrationTestNeg - [X] The following is the result of the "mvn test" command on the appropriate module: ` [ERROR] Failures: [ERROR] TestControllerLeadershipChange.testMissingTopStateDurationMonitoring:262 expected:<true> but was:<false> [ERROR] TestStateTransitionTimeoutWithResource.testStateTransitionTimeoutByClusterLevel:196 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 1148, Failures: 2, Errors: 0, Skipped: 1 [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.082 s - in org.apache.helix.integration.controller.TestControllerLeadershipChange [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.572 s - in org.apache.helix.integration.paticipant.TestStateTransitionTimeoutWithResource ` ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
