kaisun2000 commented on a change in pull request #1129:
URL: https://github.com/apache/helix/pull/1129#discussion_r447264256
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/server/TestPerInstanceAccessor.java
##########
@@ -463,5 +464,53 @@ public void testValidateWeightForInstance()
// Must have the results saying they are all valid (true) because capacity
keys are set
// in ClusterConfig
node.iterator().forEachRemaining(child ->
Assert.assertTrue(child.getBooleanValue()));
+ System.out.println("End test :" + TestHelper.getTestMethodName());
+ }
+
+ @Test(dependsOnMethods = "testValidateWeightForInstance")
Review comment:
If I understand correctly, we are testing changing instance config
domain field via rest. Here, the validation of config is actually executed from
rest server side, right?
Can we add a small comment about the purpose of this test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
