jiajunwang commented on a change in pull request #1123:
URL: https://github.com/apache/helix/pull/1123#discussion_r447932291
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/AssignmentMetadataStore.java
##########
@@ -70,7 +70,7 @@ protected AssignmentMetadataStore(BucketDataAccessor
bucketDataAccessor, String
_globalBaseline = splitAssignments(baseline);
} catch (ZkNoNodeException ex) {
// Metadata does not exist, so return an empty map
- _globalBaseline = Collections.emptyMap();
+ _globalBaseline = new HashMap<>();
Review comment:
It is. In this PR, I changed the logic so the map will be kept. It needs
to be modifiable.
Another option is to introduce more logic to handle the corner cases, which
I don't prefer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
