kaisun2000 commented on pull request #1123: URL: https://github.com/apache/helix/pull/1123#issuecomment-652006981
> You are wrong. > > 1. Both WAGED and the traditional rebalancers are for each cluster. > 2. synchronized is not a must if we make the assumption that it will only be used in the WAGED rebalancer. And we are not going to change the WAGED rebalancer. > 3. Having this to protect is a nice-to-have thing. So do you suggest we remove it? I think it won't hurt. So the invariant is that each cluster has its own copy of persisted baseline and best-possible. If this is clear, removing sync seems to be safe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
