jiajunwang commented on a change in pull request #1147:
URL: https://github.com/apache/helix/pull/1147#discussion_r454154393
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterEventMonitor.java
##########
@@ -31,6 +31,7 @@
import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric;
import org.apache.helix.monitoring.mbeans.dynamicMBeans.SimpleDynamicMetric;
+
Review comment:
I personally don't like 2 lines. It makes the code looks longer and not
concise. I see @pkuwm did that change before. @pkuwm, is there a particular
reason we want 2 lines instead of one?
And @narendly, please put the reformat changes to a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
