pkuwm commented on a change in pull request #1147:
URL: https://github.com/apache/helix/pull/1147#discussion_r454166481
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterEventMonitor.java
##########
@@ -31,6 +31,7 @@
import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric;
import org.apache.helix.monitoring.mbeans.dynamicMBeans.SimpleDynamicMetric;
+
Review comment:
@jiajunwang Double checked. The 2 lines setting is consistent with
LinkedIn's java coding convention.
I actually prefer 1 line, as well. If we agree on making it 1 line, let me
change it. Could we confirm that 1 line is preferred? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
