pkuwm commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r460270347
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1360,8 +1390,20 @@ private boolean
updateControllerState(NotificationContext changeContext, PauseSi
String uid = UUID.randomUUID().toString().substring(0, 8);
ClusterEvent event = new ClusterEvent(_clusterName,
ClusterEventType.Resume,
String.format("%s_%s", uid, Pipeline.Type.DEFAULT.name()));
+
+ HelixManager manager = changeContext.getManager();
Review comment:
To make code clean, I decided to put it the check in one place in
handleEvent(). It is fine to push stale events into queue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
